This repository was archived by the owner on Oct 31, 2025. It is now read-only.
Add spirv-tools and spirv-tools-sys crates to wrap usage of spirv-tools#179
Merged
Jake-Shadle merged 44 commits intomainfrom Oct 29, 2020
Merged
Add spirv-tools and spirv-tools-sys crates to wrap usage of spirv-tools#179Jake-Shadle merged 44 commits intomainfrom
Jake-Shadle merged 44 commits intomainfrom
Conversation
* Splits steps to clearly show how long each part of a longer (eg test) step actually takes * Label all steps
Member
Author
|
This fixes the docs deployment. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the use of spirv-tools' binaries (as, opt, and val) with the ability use the compiled C++ code instead, or in addition to the spirv binaries.
Additions
spirv-tools-syswhich buildsspirv-tools, including a small generator script that generates some includes based on spirv-headersspirv-tools-sys/src/c/opt.cppwhich is just a thin (and incomplete) C wrapper around Optimizer because C++spirv-toolscrate which provides a slighly nicer API on top ofspirv-tools-sysChanges
spirv-optbinary in link.rs withspirv_tools::opt::Optimizerspirv-valfor validating resulting binaries in link.rs withspirv_tools::val::Validatorspirv-asin the linker tests withspirv_tools::as::Assembleruse-installed-toolsanduse-compiled-toolsfeature flags, whereuse-compiled-toolsis the default feature for optimal user experience.Missing
Assemblerwill choke on hexadecimal floats, but we only use theAssemblerin tests and none of them currently use hexadecimal floats, so figured this would be ok for now, the issue is fixable but doing C++ code was making me sad so I punted until it became an actual issue.Resolves: #31